Add Copilot preference for a chat's custom instructions loading (from all projects or from referenced projects only)#136
Open
travkin79 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
iloveeclipse
reviewed
May 5, 2026
travkin79
force-pushed
the
feature/select-custom-instructions
branch
from
7c28fcc to
8c9cc48
Compare
travkin79
requested review from
duzitong,
ethanyhou,
jdneo and
xinyi-gong
as code owners
Author
|
Hi @iloveeclipse, |
There was a problem hiding this comment.
Pull request overview
This PR adds a new chat preference to control how project-level Copilot custom instructions are scoped when starting a chat, so Eclipse can avoid loading unrelated projects’ instruction files and reduce the prompt bloat behind issue #62.
Changes:
- Added a persisted
CustomInstructionsChatLoadScopepreference with UI labels/defaults for chat instruction loading. - Derived workspace folders from selected/current resources in
ChatViewand threaded that list into conversation creation. - Added enum/helper tests and
ResourceUtilscoverage for workspace-folder derivation.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/utils/ResourceUtils.java |
Adds helper to derive distinct accessible workspace folders from selected resources. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/messages.properties |
Adds user-facing labels for the new chat instruction scope preference. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/Messages.java |
Exposes new NLS message keys. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/CustomInstructionPreferencePage.java |
Adds the new combo box to the preferences UI and persists the selection. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/CopilotPreferenceInitializer.java |
Sets the default chat instruction scope preference. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/ChatView.java |
Derives scoped workspace folders before creating a new conversation. |
com.microsoft.copilot.eclipse.ui.test/src/com/microsoft/copilot/eclipse/ui/utils/ResourceUtilsTest.java |
Adds tests for workspace-folder derivation behavior. |
com.microsoft.copilot.eclipse.ui.test/META-INF/MANIFEST.MF |
Adds JUnit params dependency for new parameterized tests. |
com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/CopilotLanguageServerConnection.java |
Adds a createConversation overload that accepts scoped workspace folders. |
com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/Constants.java |
Defines the new preference key and enum values/default. |
com.microsoft.copilot.eclipse.core.test/src/com/microsoft/copilot/eclipse/core/CustomInstructionsChatLoadScopeTest.java |
Adds enum serialization/deserialization tests. |
Correct. |
travkin79
force-pushed
the
feature/select-custom-instructions
branch
2 times, most recently
from
f90fdfc to
6728703
Compare
Author
|
Hi @iloveeclipse,
I've adapted the code to retrieve custom instructions from selected files on each conversation turn, i.e. each time a new prompt is sent to the LS. |
ethanyhou
reviewed
May 6, 2026
travkin79
force-pushed
the
feature/select-custom-instructions
branch
2 times, most recently
from
cf9a3ce to
66a07f1
Compare
jdneo
reviewed
May 7, 2026
jdneo
reviewed
May 7, 2026
jdneo
reviewed
May 7, 2026
travkin79
force-pushed
the
feature/select-custom-instructions
branch
2 times, most recently
from
b897069 to
54024bc
Compare
travkin79
force-pushed
the
feature/select-custom-instructions
branch
from
54024bc to
6fd6559
Compare
jdneo
reviewed
May 8, 2026
Member
|
I have no more comments. @iloveeclipse could you help validate with this patch, your project setup will work as expected? |
I hope to get some time next week for that. |
Member
|
@travkin79 Let's wait for the confirmation, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #62 according to the comment #62 (comment)
The PR
CopilotLanguageServerConnection), i.e.Preference page preview (new group highlighted):
